Apply quoting for globbing *
and ~
in splatting.
#26232
Open
+212
−67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #24178
According to the comment added in #5188:
https://github.com/kzrnm/PowerShell/blob/26bb188c8be0cda6cb548ce1a12840ebf67e1331/test/powershell/Language/Scripting/NativeExecution/NativeUnixGlobbing.Tests.ps1#L84-L88
However, I disagree with this comment. As noted in #24178, there are cases where one wants to use splatting without enabling globbing. Therefore, I believe implementing this via a
NoteProperty
would be worth it.Additional considerations
When using an expression other than a string literal, such as
/bin/echo "a*a".Replace("a","")
, globbing is performed. This behavior is unintuitive, so I think it’s worth considering a breaking change to make it not perform globbing along with the above modification.PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright header