Skip to content

Update rename disclaimer link and improve test skipping #2291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JustinGrote merged 3 commits into from
May 15, 2026
+6 −3
Merged

Update rename disclaimer link and improve test skipping #2291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c8e877
Update Rename Disclaimer to aka.ms link
JustinGrote May 15, 2026
74df7da
Skip CanSendGetCommandRequestAsync on more CI platforms
JustinGrote May 15, 2026
6a7b3d8
Increase CanAtachScriptWIthPathMappings timeout
JustinGrote May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/PowerShellEditorServices/Services/TextDocument/RenameService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ private async Task<bool> AcceptRenameDisclaimer(bool acceptDisclaimerOption, Can
if (DisclaimerDeclinedForSession) { throw new HandlerErrorException(disclaimerDeclinedMessage); }
if (acceptDisclaimerOption || DisclaimerAcceptedForSession) { return true; }

const string renameDisclaimer = "PowerShell rename functionality is only supported in a limited set of circumstances. [Please review the notice](https://github.com/PowerShell/PowerShellEditorServices?tab=readme-ov-file#rename-disclaimer) and accept the limitations and risks.";
const string renameDisclaimer = "PowerShell rename functionality is only supported in a limited set of circumstances. [Please review the notice](https://aka.ms/powershell-rename-disclaimer) and accept the limitations and risks.";
const string acceptAnswer = "I Accept";
const string declineAnswer = "Decline";

Expand Down
2 changes: 1 addition & 1 deletion test/PowerShellEditorServices.Test.E2E/DebugAdapterProtocolMessageTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,7 @@ public async Task CanLaunchScriptWithNewChildAttachSessionAsJob()
await terminatedTcs.Task;
}

[SkippableFact(Timeout = 10000)]
[SkippableFact(Timeout = 15000)]
public async Task CanAttachScriptWithPathMappings()
{
Skip.If(PsesStdioLanguageServerProcessHost.RunningInConstrainedLanguageMode,
Expand Down
5 changes: 4 additions & 1 deletion test/PowerShellEditorServices.Test.E2E/LanguageServerProtocolMessageTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1239,7 +1239,10 @@ await PsesLanguageClient
[SkippableFact(Timeout = 120000)]
public async Task CanSendGetCommandRequestAsync()
{
Skip.If(Environment.GetEnvironmentVariable("TF_BUILD") is not null,
Skip.If(
Environment.GetEnvironmentVariable("TF_BUILD") is not null ||
Environment.GetEnvironmentVariable("GITHUB_ACTIONS") is not null ||
Environment.GetEnvironmentVariable("CI") is not null,
"This test is too slow in CI.");

List<object> pSCommandMessages =
Expand Down
Loading