Add list of frontends to README #971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmholt
requested review from
SeeminglyScience,
SydneyhSmith,
TylerLeonhardt and
rkeithhill
rkeithhill
reviewed
May 28, 2019
README.md
Outdated
| functionality needed to enable a consistent and robust PowerShell development | ||
| experience in almost any editor or integrated development environment (IDE). | ||
|
|
||
| ## Front-ends using PSES |
Contributor
There was a problem hiding this comment.
"Front-ends" is probably more recognizable to folks but technically these are language service client apps, right?
Contributor
Author
There was a problem hiding this comment.
Yeah "LSP clients" is maybe better?
Contributor
There was a problem hiding this comment.
That's a more "correct" description IMO. Whether that is meaningful to the average user who looks at this ... I dunno. Your call. :-)
Contributor
Author
There was a problem hiding this comment.
Well I'm hoiping that users who get to the PSES README probably understand it somewhat
rkeithhill
approved these changes
May 28, 2019
Contributor
rkeithhill
left a comment
rkeithhill
left a comment
There was a problem hiding this comment.
One totally minor observation otherwise LGTM.
Contributor
Author
|
I'll merge this in when the LSP page is updated, closing the issue this resolves |
TylerLeonhardt
approved these changes
Jun 2, 2019
Co-Authored-By: Tyler James Leonhardt <tylerl0706@gmail.com>
Co-Authored-By: Tyler James Leonhardt <tylerl0706@gmail.com>
Co-Authored-By: Tyler James Leonhardt <tylerl0706@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #969