Fix for username char case bug in Windows platform#86
Merged
PaulHigin merged 2 commits intoPowerShell:masterfrom Oct 4, 2021
Merged
Fix for username char case bug in Windows platform#86PaulHigin merged 2 commits intoPowerShell:masterfrom
PaulHigin merged 2 commits intoPowerShell:masterfrom
Conversation
SteveL-MSFT
reviewed
Sep 29, 2021
anamnavi
reviewed
Oct 1, 2021
anamnavi
approved these changes
Oct 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the UserName character case bug (Issue #62) on Windows platforms. Where the UserName returned by environment variable or WindowsIdentity API is incorrect and reflects what the user typed in the RunAs command instead.
The UserName is used to encrypt data to avoid having plain text in some files (store configuration data), and also as a replacement for the no-password configuration (where file system protections are relied on for a less secure but more convenient configuration).
A consistent UserName is vital and if it is provided by the OS in different character casing, data cannot be decrypted and read.
Fix is to convert the provided UserName to all upper case to ensure consistent values. Fix also includes a fallback option to use the original character casing when reading old data (that hasn't been updated to the all upper case).