Skip to content

Detect ARM64 host MSBuild in Get-MSBuildPath#847

Merged
tgauth merged 1 commit into
PowerShell:latestw_allfrom
g-chauvel:fix/arm64-msbuild-host-detection
May 14, 2026
Merged

Detect ARM64 host MSBuild in Get-MSBuildPath#847
tgauth merged 1 commit into
PowerShell:latestw_allfrom
g-chauvel:fix/arm64-msbuild-host-detection

Conversation

@g-chauvel
Copy link
Copy Markdown

PR Summary

When building on a Windows ARM64 host, Get-MSBuildPath currently resolves to the HostX86 toolchain

    31>ClCompile:
         C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.44.35207\bin\HostX86\arm64\CL.exe

instead of the native HostArm64 toolchain.

      ClCompile:
         C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.44.35207\bin\HostArm64\arm64\CL.exe

PR Context

Copilot AI review requested due to automatic review settings May 11, 2026 14:04
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Windows build helper to prefer the native ARM64 MSBuild binary when running on an ARM64 environment, avoiding selection of an x86 MSBuild that can lead to the HostX86\arm64 toolchain being used.

Changes:

  • Extend Get-MSBuildPath to append the \arm64 MSBuild subdirectory when PROCESSOR_ARCHITECTURE=ARM64.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread contrib/win32/openssh/OpenSSHBuildHelper.psm1 Outdated
@g-chauvel g-chauvel force-pushed the fix/arm64-msbuild-host-detection branch 9 times, most recently from 82823e5 to fec2d77 Compare May 12, 2026 18:29
@tgauth
Copy link
Copy Markdown
Collaborator

tgauth commented May 14, 2026

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@tgauth tgauth merged commit 6cfba74 into PowerShell:latestw_all May 14, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants