Skip to content

Adding check for empty string as well as null#102

Open
reubenmiller wants to merge 1 commit intoPowerShellOrg:masterfrom
reubenmiller:bugfix-resolve-cred
Open

Adding check for empty string as well as null#102
reubenmiller wants to merge 1 commit intoPowerShellOrg:masterfrom
reubenmiller:bugfix-resolve-cred

Conversation

@reubenmiller
Copy link
Copy Markdown

When using the -Credentials parameter when calling Invoke-PSDepend for dependencies that don't require credentials, would result in the erroneous warning WARNING: No credential found for the specified name . Was the dependency misconfigured?

Example

Invoke-PSDepend -Path "./depends.psd1" -Install -Import -Credentials @{
  "repo1WithCredential" = (Get-Credential)
}

File depends.psd1

@{
    "PSModule1" = @{
        
        "Name"           = "PSModule1"
        "Version"        = "1.0.0"
        "DependencyType" = "PSGalleryModule"
        "Credential"     = "repo1WithCredential"
        "Parameters"     = @{
            "Repository" = "repo1WithCredential"
        }
    }
    "PSModule2" = @{
        "Name"           = "PSModule2"
        "Version"        = "2.1.0"
        "DependencyType" = "PSGalleryModule"
        "Parameters"     = @{
            "Repository" = "repo2WithoutCredential"
        }

Would generate the warning when processing the PSModule2 dependency.

WARNING: No credential found for the specified name . Was the dependency misconfigured?

Fix

The -Name parameter in Resolve-Credential is cast from $null to an empty string "". So now both null and an empty string are checked.

@reubenmiller
Copy link
Copy Markdown
Author

Resolves $null credential issue referenced at the end of #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant