fix(tests): mock Install-Dotnet in DotnetSdk install test#178
Merged
Conversation
The test was calling the real dotnet-install script, which requires network access and produces no local artifacts on CI runners. Replace the filesystem assertion with a Should -Invoke check against a proper Install-Dotnet mock. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a test in Tests/PSModuleGallery.Type.Tests.ps1 that was inadvertently acting as an integration test by invoking the real dotnet-install script. The fix mocks Install-Dotnet and replaces a filesystem-based assertion with a Should -Invoke check on the mock.
Changes:
- Add
Mock Install-Dotnetalongside the existingMock Test-Dotnet. - Replace
Test-Path $script:SavePath | Should -BeTruewithShould -Invoke Install-Dotnetusing a$InstallDirparameter filter.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DotnetSdk Type > Installs Dependency > Installs the .NET Core SDK to the specified directorytest was an accidental integration test — it mockedTest-Dotnetbut leftInstall-Dotnetunmocked, causing it to invoke the real dotnet-install script on CI runners..dotnetpath that doesn't exist on runners, soTest-Path '.dotnet'always returned$false.Mock Install-Dotnetand replace the filesystem assertion withShould -Invoke Install-Dotnet -Times 1 -Exactlywith a$InstallDirparameter filter.Test plan
Tests/PSModuleGallery.Type.Tests.ps1— 89 tests, all pass locally🤖 Generated with Claude Code