for call fail attempts try another 10 times and then stop#9
Merged
Conversation
stask
requested changes
Feb 28, 2021
| (if (nil? uri) | ||
| (loop [results [] | ||
| uri uri | ||
| attempts 10 |
Member
There was a problem hiding this comment.
Please use constant here (similar to backoff-timeout)
| ;; load balancer freaking out, lets try again | ||
| (Thread/sleep 1000) | ||
| (recur results uri params)) | ||
| (recur results uri (dec attempts) params)) |
Member
There was a problem hiding this comment.
You don't test if attempts is greater than 0 here
| (log/warnf "API rate limit reached, waiting for %s seconds" backoff-timeout) | ||
| (Thread/sleep (* backoff-timeout 1000)) | ||
| (recur results uri params)) | ||
| (recur results (dec attempts) uri params)) |
Member
There was a problem hiding this comment.
here too, you don't check if attempts is positive
| (concat results data) | ||
| (conj results data))) | ||
| (get-in body [:links :next]) | ||
| (dec attempts) |
Member
There was a problem hiding this comment.
Why do you decrement attempts here?
stask
requested changes
Feb 28, 2021
| ;; utils | ||
|
|
||
| (def backoff-timeout "Backoff timeout in seconds" 20) | ||
| (def num-attemps "Number of attempts to run" 10) |
Member
There was a problem hiding this comment.
typo: num-attempts (missing t before s)
Actually better call it max-attempts
stask
approved these changes
Feb 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.