fix: resolve IndexError in exporter and add timeout flag to run command#10
Merged
practicalmind-dev merged 1 commit intoMay 18, 2026
Conversation
Fixes PracticalMind#8: exporter.py now uses a fixed _FIELDS constant instead of deriving field names from records[0].keys(), preventing IndexError when results list is empty. Added guard so CSV writer skips rows when there are no records. Fixes PracticalMind#9: added --timeout option to the run CLI command (default 30s). Timeout is now passed through run_all() and _run_one() instead of using a hardcoded module-level _TIMEOUT constant. Updated tests: added 3 new tests for empty-results export, updated test_run_one_records_timeout to pass timeout directly.
Contributor
|
Thanks for the clean fixes and the tests, merging this in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8: exporter.py now uses a fixed _FIELDS constant instead of deriving field names from records[0].keys(), preventing IndexError when results list is empty. Added guard so CSV writer skips rows when there are no records.
Fixes #9: added --timeout option to the run CLI command (default 30s). Timeout is now passed through run_all() and _run_one() instead of using a hardcoded module-level _TIMEOUT constant.
Updated tests: added 3 new tests for empty-results export, updated test_run_one_records_timeout to pass timeout directly.