Skip to content

New algorithm implementation#381

Merged
Pradeepsingh61 merged 3 commits into
Pradeepsingh61:mainfrom
PragatiGHub:knights
Oct 3, 2025
Merged

New algorithm implementation#381
Pradeepsingh61 merged 3 commits into
Pradeepsingh61:mainfrom
PragatiGHub:knights

Conversation

@PragatiGHub
Copy link
Copy Markdown

📋 Pull Request Description

What does this PR add?

  • New algorithm implementation
  • Data structure implementation
  • New programming language support
  • Language-specific README
  • Bug fix
  • Documentation improvement
  • Test cases

Algorithm/Feature Details

  • Name: Knight's Tour
  • Language: Python
  • Category: Backtracking / Graph Traversal
  • Time Complexity: O(8^(n²)) in the worst case (exponential)
  • Space Complexity: O(n²) for the board and recursion stack

Testing

  • Code compiles without errors
  • Multiple board sizes tested (5×5, 6×6, 8×8)
  • Edge cases handled (e.g., 3×3 board – no solution expected)
  • Documentation and in-code comments added for clarity

Screenshots (if applicable)

[Add screenshots of output]

Additional Notes

  • Implemented Knight's Tour using Backtracking and Warnsdorff’s heuristic for optimization.
  • The solution includes utility functions for validation, multiple tours, and formatted board printing.
  • Code is modular and easy to extend for visualization or further testing.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 3, 2025

💎 Code Quality Check Results

❌ Missing Complexity Analysis

These files don't include time/space complexity:

  • CPP/algorithms/greedy_algorithms/huffman_algo.cpp
  • Python/algorithms/backtracking/knights_tour.py

Required: Add comments explaining time and space complexity (e.g., Time: O(n log n), Space: O(n))

📚 Quality Standards

To maintain high quality, every contribution should include:

  1. ✍️ Algorithm Description

    • Explain what the algorithm does
    • Describe the approach and methodology
    • Include use cases or applications
  2. 📊 Complexity Analysis

    • Time complexity (e.g., O(n log n))
    • Space complexity (e.g., O(n))
    • Brief explanation of why
  3. 💬 Meaningful Comments

    • Explain complex logic
    • Document function parameters
    • Add inline comments for clarity
  4. ✅ Test Cases/Examples

    • Demonstrate the code works
    • Show different input scenarios
    • Include edge cases

💡 Example Template

"""
Binary Search Algorithm

Description: Searches for a target value in a sorted array using divide-and-conquer

Time Complexity: O(log n) - halves search space each iteration
Space Complexity: O(1) - only uses constant extra space
"""

def binary_search(arr, target):
    # Initialize pointers
    left, right = 0, len(arr) - 1

    while left <= right:
        mid = (left + right) // 2

        # Check if target found
        if arr[mid] == target:
            return mid
        # Search right half
        elif arr[mid] < target:
            left = mid + 1
        # Search left half
        else:
            right = mid - 1

    return -1  # Not found

# Test cases
if __name__ == "__main__":
    test_arr = [1, 3, 5, 7, 9]
    print(binary_search(test_arr, 5))  # Output: 2
    print(binary_search(test_arr, 6))  # Output: -1

🔧 How to Fix

  1. Review each file mentioned above
  2. Add the missing documentation
  3. Push your changes
  4. The workflow will re-run automatically

💪 You've Got This!

These checks help maintain quality and make your contribution more valuable to learners. Thank you for taking the time to improve! 🙏


Quality over quantity - let's build something amazing together! 🌟

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 3, 2025

🔍 Duplicate Detection Results

⚠️ Potential Duplicates Found

⚠️ Potential Duplicate: CPP/algorithms/greedy_algorithms/huffman_algo.cpp
Similar file(s) already exist:

  • CPP/algorithms/greedy_algorithms/huffman_algo.cpp

⚠️ Potential Duplicate: Python/algorithms/backtracking/knights_tour.py
Similar file(s) already exist:

  • Python/algorithms/backtracking/knights_tour.py

⚠️ Potential Duplicate: Python/algorithms/sorting/merge_sort.py
Similar file(s) already exist:

  • Python/algorithms/sorting/merge_sort.py

📝 What This Means

We found existing implementations that appear similar to your contribution. This doesn't necessarily mean your PR will be rejected, but please review:

  1. Is this truly a duplicate? Check the existing files to see if they implement the same algorithm
  2. Is your implementation different/better? If so, explain in your PR description:
    • What makes it different
    • Why it's an improvement
    • Any unique features or optimizations
  3. Consider improving existing code instead of adding a duplicate

✅ What To Do Next

  • If it's a duplicate: Consider withdrawing this PR and improving the existing implementation
  • If it's different: Add a clear explanation in your PR description about how it differs
  • If unsure: Ask the maintainers for guidance!

💡 Quality Over Quantity

Remember: One high-quality, unique contribution is worth more than multiple duplicates! 🌟


This is an automated check. Maintainers will make the final decision.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 3, 2025

🎉 Welcome to Hacktoberfest 2025, @PragatiGHub! 🎃

Thank you for your first contribution to our DSA repository! Here's what happens next:

🔍 Automatic Checks

  • Code Validation: Passed
  • 🧪 Compilation Tests: Passed

📋 Next Steps

🎯 Great job! Your code compiled successfully. Maintainers @Karanjot786 and @Pradeepsingh61 will review your PR soon.

🎁 What You Get

  • 🏆 Hacktoberfest Credit: This PR counts toward your 6 PR goal for exclusive T-shirt + Tree!
  • 🌟 Hall of Fame: You'll be featured in our contributors list
  • 📚 Learning: Code review feedback from experienced developers

💡 Tips for Success

  • Follow our Contributing Guidelines
  • Add comments explaining your algorithm
  • Include time/space complexity analysis
  • Test your code before submitting

Welcome to the community! 🚀

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 3, 2025

🤖 Automated PR Status

🔍 Code Validation

Passed - File naming and structure look good!

🧪 Compilation Tests

Passed - All code compiles successfully!

📋 Overall Status

🎉 Ready for Review - Your PR has passed all automated checks!
👥 Maintainers have been notified for review.


This comment was generated automatically. Checks will re-run when you push new commits.

@github-actions github-actions Bot requested a review from Karanjot786 October 3, 2025 15:46
@Pradeepsingh61 Pradeepsingh61 merged commit c7d03e6 into Pradeepsingh61:main Oct 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants