Conversation
Signed-off-by: entorge <96802968+entorge@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
ESLint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Signed-off-by: entorge <96802968+entorge@users.noreply.github.com>
Signed-off-by: entorge <96802968+entorge@users.noreply.github.com>
Signed-off-by: entorge <96802968+entorge@users.noreply.github.com>
Signed-off-by: entorge <96802968+entorge@users.noreply.github.com>
theusaf
changed the title
theusaf
left a comment
theusaf
left a comment
There was a problem hiding this comment.
Activities require a metadata file. Also, please see developer documentation for how examples on how an Activity is coded
|
Hi @theusaf. I have updated the PR to address your points: Metadata: Fixed metadata.json by adding apiVersion, correcting the category to videos, and switching to a local logo.png asset. Refactoring: Rewrote presence.ts to use the UpdateData event listener and removed the manual setInterval loop to align with the current developer documentation. |
theusaf
left a comment
theusaf
left a comment
There was a problem hiding this comment.
Still missing metadata file. Also attach screenshots showing your Activity working
| } | ||
|
|
||
| const presenceData = { | ||
| type: 3, |
There was a problem hiding this comment.
use enum rather than number
| updatePresence() | ||
| setInterval(updatePresence, 10000) |
There was a problem hiding this comment.
Use the updatedata event as mentioned in documentation
| @@ -0,0 +1,36 @@ | |||
| (async () => { | |||
There was a problem hiding this comment.
Script does not need to be in a top-level anonymous function
|
@theusaf I removed the top-level anyonymous function, switched to enum, and used the UpdateData event listener. 
|
|
Please verify that you are making changes on the correct branch |
Signed-off-by: entorge <96802968+entorge@users.noreply.github.com>
Added a newline at the end of the metadata.json file. Signed-off-by: entorge <96802968+entorge@users.noreply.github.com>
Signed-off-by: entorge <96802968+entorge@users.noreply.github.com>
Signed-off-by: entorge <96802968+entorge@users.noreply.github.com>
Signed-off-by: entorge <96802968+entorge@users.noreply.github.com>
Signed-off-by: entorge <96802968+entorge@users.noreply.github.com>
Signed-off-by: entorge <96802968+entorge@users.noreply.github.com>
Signed-off-by: entorge <96802968+entorge@users.noreply.github.com>
Signed-off-by: entorge <96802968+entorge@users.noreply.github.com>
Signed-off-by: entorge <96802968+entorge@users.noreply.github.com>
Signed-off-by: entorge <96802968+entorge@users.noreply.github.com>
Signed-off-by: entorge <96802968+entorge@users.noreply.github.com>
Signed-off-by: entorge <96802968+entorge@users.noreply.github.com>
Signed-off-by: entorge <96802968+entorge@users.noreply.github.com>
Signed-off-by: entorge <96802968+entorge@users.noreply.github.com>
Signed-off-by: entorge <96802968+entorge@users.noreply.github.com>
Signed-off-by: entorge <96802968+entorge@users.noreply.github.com>
Signed-off-by: entorge <96802968+entorge@users.noreply.github.com>
|
Should be good to go now. |
theusaf
left a comment
theusaf
left a comment
There was a problem hiding this comment.
Apologies for the wait. There are a few more issues to address.
| "logo": "https://media.discordapp.net/attachments/960887054273769474/1472581570391969965/logo.png?ex=699317f5&is=6991c675&hm=6728347af8d2eefcc77bc5de0ccfa9e4f8d0b448d0d274b6d11c3f789d6c2f58&=&format=webp&quality=lossless&width=563&height=563", | ||
| "thumbnail": "https://media.discordapp.net/attachments/960887054273769474/1472581570777976993/thumbnail.png?ex=699317f5&is=6991c675&hm=bad4de40413ef5cbfdf165defd9086332efe0598fa2fa2b33a678904ccec9c7e&=&format=webp&quality=lossless&width=563&height=563", |
There was a problem hiding this comment.
Unfortunately, you cannot use Discord URLs here since Discord invalidates the URL after a short period of time. Re-upload the images to a separate location and use that URL
| type: ActivityType.Watching, | ||
| details: detailsText, | ||
| state: stateText, | ||
| largeImageKey: 'logo', |
There was a problem hiding this comment.
Use image URL instead of Discord asset key
Updated logo and thumbnail URLs in metadata.json. Signed-off-by: entorge <96802968+entorge@users.noreply.github.com>
Signed-off-by: entorge <96802968+entorge@users.noreply.github.com>
Signed-off-by: entorge <96802968+entorge@users.noreply.github.com>
|
I found this alternative image hosting site, let me know if this'll work. |
| "logo": "https://i.ibb.co/C5n7tX9h/logo.png", | ||
| "thumbnail": "https://i.ibb.co/JwBpMWp9/thumbnail.png", |
There was a problem hiding this comment.
they're fine on my end, just a bit delayed load time. if you have a better alternative, then out with it
Co-authored-by: Bas van Zanten <bas.van.zanten007@gmail.com> Signed-off-by: entorge <96802968+entorge@users.noreply.github.com>
Head branch was pushed to by a user without write access
4 participants
This PR adds support for Rally.TV. It tracks the current live video or highlights being watched by scraping the active .live container. It implements a string-split logic using the | separator to clean up the display across the Details and State fields in Discord