fix(Nebula): bug where video details weren't showing#10462
Merged
Bas950 merged 2 commits intoPreMiD:mainfrom Jan 29, 2026
Merged
fix(Nebula): bug where video details weren't showing#10462Bas950 merged 2 commits intoPreMiD:mainfrom
Bas950 merged 2 commits intoPreMiD:mainfrom
Conversation
fix bug where reliance on aria-label="video description" caused no video details to show. removed the `aria-label="video description"` container and query `main h1` and `main h2` directly for video title and channel name.
|
lgtm! |
AAK-5307
approved these changes
Jan 28, 2026
theusaf
approved these changes
Jan 29, 2026
3 tasks
Bas950
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix bug where reliance on
aria-label="video description"caused no video details to show. Nebula removed thearia-label="video description"container siteside, or atleast the label for it. fix is to querymain h1andmain h2directly for video title and channel name rather than checking the container.Acknowledgements
npm run lintScreenshots
Proof showing the creation/modification is working as expected
Old Behavior:
Fixed Behavior: