FITB: Dynamic substitutions require node modules be installed.#1018
Merged
oscarlevin merged 3 commits intoPreTeXtBook:mainfrom Jul 9, 2025
Merged
FITB: Dynamic substitutions require node modules be installed.#1018oscarlevin merged 3 commits intoPreTeXtBook:mainfrom
oscarlevin merged 3 commits intoPreTeXtBook:mainfrom
Conversation
Member
|
Thanks. I edited one of the error messages and updated the core commit to make sure it had the most recent changes. Worked well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe that this captures the CLI requirements to match pretext PR #2577. Before the dynamic substitution extraction routine in core can be called, we need to ensure that the associated node packages are installed. (In pretext/script/dynsub). Node can't load the dynamic JS libraries that Runestone components require for versions below 22.10, and which is required to generate the randomized content that is being extracted.
I made three key changes mimicking what was happening with themes (also require npm install), but don't know how to test them:
I don't know of any other changes that would be required. This is more intended to point out what I understand would be needed, and I hope it is enough for you to understand if anything else is missing.