Add Kotlin capability#2719
Conversation
|
This looks great functionally. It is hard to know for sure without the RS side, but I have a high degree of confidence it is doing all the necessary things. The only issues I see are with documentation and commits.
Feel free to do an interactive rebase and force push to the PR with adjustments. |
|
This looks good visually. One comment: the schema files are derived from a "literate programming" version in PreTeXt itself. Have a read here. Don't do anything about it now. Generally, as a public service, I will rebuild those files as part of a merge and I can fix up the edits here already. |
|
Thanks for the help, @ascholerChemeketa and @rbeezer. I've updated the PR; let me know if I need to make more changes or if all is good. |
|
Nice job on a well-formed pull request - especially on your first time out. Thanks. I rotated a couple of commits, and fleshed out the schema changes. Otherwise merged as-is (but of course commits have changed, so your branch should be deleted and you can get caught up with a pull). Once tested on Runestone and with more examples, we can make any necessary updates. |
This PR adds capability to PreTeXt to handle Kotlin code. I've added an example in the sample book to show its use. If the book is built to static html, this seems to be sufficient to make everything work. For interactive code that runs on a Runestone server, there are changes that need to come to the Runestone code base... but this needs to be in place first. (I've got those changes ready to go, but I'm starting here.)
Thanks! If I can clean this up or help in some way, please let me know.