Runestone: add termStartDate to eBookConfig#2804
Closed
ascholerChemeketa wants to merge 1 commit intoPreTeXtBook:masterfrom
Closed
Runestone: add termStartDate to eBookConfig#2804ascholerChemeketa wants to merge 1 commit intoPreTeXtBook:masterfrom
ascholerChemeketa wants to merge 1 commit intoPreTeXtBook:masterfrom
Conversation
Contributor
Author
|
RS PR: RunestoneInteractive/rs#1185 |
rbeezer
reviewed
Mar 25, 2026
Collaborator
rbeezer
left a comment
rbeezer
left a comment
There was a problem hiding this comment.
Tested with the sample book using both the noparts (non-hosted) and academy (Runestone-hosted) publication files.
- Non-hosted build: zero changes (as expected, the new line is only in the hosted branch)
- Hosted build:
eBookConfig.termStartDateappears on all 107 pages with the correct Jinja2 template variable
The new line follows the established pattern for all other eBookConfig fields.
🤖 Review by Claude Opus 4.6
rbeezer
pushed a commit
that referenced
this pull request
Mar 25, 2026
Collaborator
|
Yes, Claude was overkill for this, but now it "knows" how to review Runestone features. Before/after academy-hosted/generic-hosted tested manually. @bnmnetp mentioned this feature in Drop-In yesterday, thanks for keeping the PreTeXt side current. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a single field to the
eBookConfigto support a RS PR that will prevent student work done before the start of a class (e.g. when a student is repeating a course using the same book) from counting.