Merged
Conversation
case 38185
aypreviser
reviewed
Dec 28, 2023
aypreviser
reviewed
Dec 28, 2023
aypreviser
reviewed
Dec 28, 2023
aypreviser
reviewed
Dec 28, 2023
aypreviser
requested changes
Dec 28, 2023
aypreviser
left a comment
aypreviser
left a comment
There was a problem hiding this comment.
I have successfully run the humpback migration for PDH and does a schema and data comparison.
Changes required:
- Removing excess files. (see comments)
- executable should be hump.exe
- Assembly version is incorrect
This version was expected to be 0.2.1.0 => it's currently showing 0.0.0.0
|
The links are missing for the SharedVersionInfo.cs
|
Author
|
aypreviser
requested changes
Jan 18, 2024
aypreviser
left a comment
aypreviser
left a comment
There was a problem hiding this comment.
required link assembles missing in humpback.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated to utilize nuget SMO packages and dotnet 4.7.2