validation_tests.rs expansion

[greatest0fallt1me]

Description

• Cover every validator branch; dedupe with integration tests where redundant.

Requirements and context

• Must be secure, tested, and documented.
• Should be efficient and easy to review for auditors and integrators.
• Scope is Predictify Hybrid Soroban smart contracts in predictify-contracts only (no frontend or backend services).

Suggested execution

• Fork the repository and create a branch:
  • git checkout -b feature/validation-tests
• Implement changes:
  1. Contract / module: update logic in contracts/predictify-hybrid/src/validation.rs and related modules as required.
  2. Tests: extend or add validation_tests.rs (and supporting test utilities under contracts/predictify-hybrid/src/tests/ when applicable).
  3. Documentation: update or add docs/api/API_DOCUMENTATION.md; add a link from docs/README.md when adding new top-level docs.
  4. Comments: use Rust doc comments (///, //!) on all new or changed public contract API — equivalent discipline to NatSpec for Solidity.

Primary touchpoints: contracts/predictify-hybrid/src/validation.rs

Test and commit

• Run cargo test -p predictify-hybrid and narrow with filters while iterating.
• Add regression tests for every bug or ambiguity found during review.
• In the PR, include summarized test output and short security notes (threat model, invariants proven, explicit non-goals).

Example commit message

test(contract): expand validation_tests

Guidelines

• Target ≥ 95% line coverage on modules touched (e.g. cargo llvm-cov / cargo tarpaulin per repo conventions).
• Documentation must be sufficient for an external integrator without reading all Rust internals.
• Timeframe: 96 hours from assignment.

[drips-wave]

This issue has been added to the Stellar Wave Program and is worth 200 Points.

🧑‍💻 Interested in contributing? Apply to work on this issue on Drips Wave, earn points, and receive rewards.

Warning

Only applications submitted via the apply link above will be considered. Please do not apply by commenting on the issue or opening a PR directly.

🤠 Repo maintainers: You can manage this issue's Points and Complexity on your Maintainer Dashboard here. Please keep an eye on applications and respond quickly 💙

ℹ️ Learn more about Drips Wave

[rosemary21]

@rosemary21 has applied to work on this issue as part of the Stellar Wave Program's 3rd wave.

I’d like to work on this issue because it focuses on smart contract correctness, security, and auditability—which are critical in any blockchain-based system, especially one handling predictions or financial logic. Given that the scope is limited to the predictify-contracts repository and involves Hybrid Soroban smart contracts, this is a high-impact opportunity to strengthen guarantees at the protocol level rather than just at the application layer.I’d like to work on this issue because it focuses on smart contract correctness, security, and auditability—which are critical in any blockchain-based system, especially one handling predictions or financial logic. Given that the scope is limited to the predictify-contracts repository and involves Hybrid Soroban smart contracts, this is a high-impact opportunity to strengthen guarantees at the protocol level rather than just at the application layer.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @rosemary21 to this issue.

[drips-wave]

Congratulations, @rosemary21! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on March 30, 2026.

🧑‍💻 @rosemary21: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[drips-wave]

This issue has been completed by @rosemary21 as part of the Stellar Wave Program's 3rd Wave 🥳

😎 @rosemary21: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.