feat: make snack bar less invasive #969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
另外这个 Dismiss 也许可以去掉 |
Owner
|
看上去相当棒，唯一的问题是我不确定居中的 toast 是否符合 material 规范 因为 Google 自己的应用一般将 toast 放置在左侧，我看一下文档，当然我觉得左侧也不一定是个好主意，在我们的用例下可能很丑 |
Contributor
Author
|
设计文档上是允许的 
|
Owner
|
我在编写这部分代码的时候就注意到了文档中的建议 也就是我们不应该有一个作用只是隐藏 toast 的按钮，但是我觉得我们还是需要它的。Google 某些站点中在这个位置有相同的按钮但命名为 Got it! 不过我突然找不到相关的例子了 |
Contributor
Author
实际上打开 Material Design 3 的网站就会有一个 Got it，理论上这个 snack bar 是常驻的，但是我不知道为什么它会在一瞬间消失 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这样不会侵占到电脑左侧边栏，更接近 toast