修复某些番剧正向排列而导致的列表反向 #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
感谢你的工作 但这个修复似乎不是很严谨，在番剧剧集长度超过 14 集，单页无法全部展示时，当前 PR 中的修改或导致剧集位置混乱 也许我们应该在这个 PR 的位置根据当前判断逻辑设置一个 flag ，在这个方法的末尾，例如 L78 根据 flag 进行反转 |
Contributor
Author
|
据我观察只有少数很老的番才会有反向排列，而这些老番都不超过14集，目前我还没有找到超过14集的反向番剧来测试，如果您有看到超过14集的排列反向番剧的链接我可以加上并进行测试 |
Owner
|
我也没有实际找到过这种番剧，只是本着健壮性方面的考虑。 上面提议的修改应该增加了健壮性。 |
Contributor
Author
|
我把判断逻辑后移到获取完完整列表后并用一个变量在第一页缓存了第一个标题来进行判断了 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #46