Conversation
Add --unstable-detect-cjs flag and DENO_UNSTABLE_DETECT_CJS env var for Deno 2.x CommonJS compatibility. Set V8 max-old-space-size to 4096MB to prevent WASM OOM during Pyodide init. Normalize backslash paths in runner.js VFS mounting. Install Deno in CI and remove Windows skip from sandbox tests. Closes #393
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Pyodide sandbox fails completely on Windows due to three independent issues reported in #393. All three are fixed here, and the Windows skip is removed from CI so they're tested going forward.
CommonJS detection: Deno 2.x needs
--unstable-detect-cjsto load Pyodide's npm package, which uses CommonJS modules.WASM OOM: Pyodide's ~20MB WASM binary exceeds Deno's default V8 heap on Windows. Setting
--max-old-space-size=4096prevents the crash during initialization.Backslash paths:
runner.jsuseswalk()paths directly for Pyodide's VFS, which only understands forward slashes. On Windows,entry.pathcontains backslashes, soprefab_ui\components\button.pygets mounted at the wrong path.CI now installs Deno on all platforms so the sandbox tests run on Windows.
Closes #393