Fix hardcoded Prefect version in PrefectServer controller test #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was expecting prefecthq/prefect:3.1.13-python3.12 but the default version was updated to 3.4.14. Updated the test to dynamically use DEFAULT_PREFECT_VERSION constant instead of hardcoding the version, making it compatible with automatic version bumps. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
mitchnielsen
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a failing unit test that was hardcoding the Prefect image version. The test expected
prefecthq/prefect:3.1.13-python3.12but the default version was updated to3.4.14in recent changes.Changes
DEFAULT_PREFECT_VERSIONconstant instead of hardcoding3.1.13.envrcfile to automatically activate mise environment when availableThis makes the test compatible with automatic Prefect version bumps and should prevent similar failures in the future.
Related: https://github.com/PrefectHQ/prefect-operator/actions/runs/17404451439/job/49405070158
🤖 Generated with Claude Code