[UI v2] feat: Start flow runs data table UX #17168
Conversation
devinvillarosa
requested review from
aaazzam,
desertaxle,
devangrose and
pleek91
as code owners
| export type FlowRunWithFlow = FlowRun & { | ||
| flow: Flow; | ||
| }; |
There was a problem hiding this comment.
For context I believe this type is around mostly because the FlowRun model doesn't have flow_name but just flow_id. In cloud we recently added flow_name to the model and got rid of this type and the extra fetching to get the flow.
There was a problem hiding this comment.
Do you know if flow_name will be available for OSS soon?
I think this would help a lot in future development
There was a problem hiding this comment.
idk that there's plan to do so but I'm sure we can make a plan to add it
| const meta: Meta<typeof FlowRunsDataTable> = { | ||
| title: "Components/FlowRuns/DataTable/FlowRunsDataTable", | ||
| decorators: [routerDecorator], |
There was a problem hiding this comment.
Ooo is this the fix for the router issues you mentioned last week?
There was a problem hiding this comment.
this is something else.
It just allows us to use router dependent components in stories without breaking,
The one I was mentioning last week is for tests
| id: "deployment", | ||
| header: "Deployment", | ||
| cell: (props) => { | ||
| const deployment = props.getValue() as Deployment; |
There was a problem hiding this comment.
Is it possible to make this type safe rather than using as? Maybe a type guard?
There was a problem hiding this comment.
edit: I think I've figured it out. Needed to define the table schema to be more specific to the table
| }; | ||
|
|
||
| type FlowRunsDataTableProps = { | ||
| flowRuns: Array<FlowRunWithDeploymentAndFlow | FlowRunWithFlow>; |
There was a problem hiding this comment.
FWIW I think the "WithDeployment..." type is around for the same reason as the WithFlow type. Because deployment_name doesn't exist on the flow run model. Just context, not requesting any change.
devinvillarosa
force-pushed
the
start-flow-runs-data-table
branch
from
0ebd483 to
308ca66
Compare
Starts flow runs data table with basic columns. Will incrementally add columns based on original vue component .
Will also incrementally add server-side filters
Checklist
<link to issue>"mint.json.Relates to #15512