Skip to content

[UI v2] feat: Adds Runs list to deployment runs tab #17246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
devinvillarosa merged 1 commit into from
Feb 25, 2025
Merged

[UI v2] feat: Adds Runs list to deployment runs tab #17246

devinvillarosa merged 1 commit into from
Feb 25, 2025

Conversation

@devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Feb 22, 2025 •
edited
Loading

[UI v2] feat: Adds Runs list to deployment runs tab

Screen.Recording.2025-02-24.at.8.11.52.PM.mov

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Relates to #15512

@devinvillarosa devinvillarosa added the DONT MERGE This PR shouldn't be merged (yet) label Feb 22, 2025
@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Feb 22, 2025
@devinvillarosa devinvillarosa force-pushed the devin/eng-1278-deploymentid-runs-tab-add-runs-list-section branch 4 times, most recently from 4787341 to 040ec09 Compare February 25, 2025 04:15
@devinvillarosa devinvillarosa removed the DONT MERGE This PR shouldn't be merged (yet) label Feb 25, 2025
@devinvillarosa devinvillarosa marked this pull request as ready for review February 25, 2025 04:18
devinvillarosa
devinvillarosa commented Feb 25, 2025
View reviewed changes
ui-v2/src/components/flow-runs/flow-runs-list/use-flow-runs-selected-rows.ts
Copy link
Contributor Author

@devinvillarosa devinvillarosa Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved this to a re-usable hook

@devinvillarosa devinvillarosa force-pushed the devin/eng-1278-deploymentid-runs-tab-add-runs-list-section branch 3 times, most recently from 84797d0 to 8dc0c9c Compare February 25, 2025 19:48
devinvillarosa
devinvillarosa commented Feb 25, 2025
View reviewed changes
ui-v2/src/components/deployments/deployment-schedules/schedule-toggle-switch.tsx
onSuccess: () =>
toast({
title: `Deployment schedule ${checked ? "active" : "inactive"}`,
title: `Deployment schedule ${checked ? "active" : "paused"}`,
Copy link
Contributor Author

@devinvillarosa devinvillarosa Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing wording from a previous PR

@devinvillarosa devinvillarosa force-pushed the devin/eng-1278-deploymentid-runs-tab-add-runs-list-section branch 3 times, most recently from bd67bee to e1915c0 Compare February 25, 2025 20:48
@devinvillarosa devinvillarosa force-pushed the devin/eng-1278-deploymentid-runs-tab-add-runs-list-section branch from e1915c0 to 576801d Compare February 25, 2025 22:05
pleek91
pleek91 approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@pleek91 pleek91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@devinvillarosa devinvillarosa merged commit 764b79f into main Feb 25, 2025
9 checks passed
@devinvillarosa devinvillarosa deleted the devin/eng-1278-deploymentid-runs-tab-add-runs-list-section branch February 25, 2025 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aaazzam aaazzam Awaiting requested review from aaazzam aaazzam is a code owner

@desertaxle desertaxle Awaiting requested review from desertaxle desertaxle is a code owner

@devangrose devangrose Awaiting requested review from devangrose

1 more reviewer

@pleek91 pleek91 pleek91 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ui-replatform Related to the React UI rewrite

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@devinvillarosa @pleek91