[UI v2] Turn on linting with biome and fix lint errors #17748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desertaxle
changed the title
desertaxle
force-pushed
the
lint-with-biome
branch
from
2bf88a3 to
bd6c6cd
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Copilot reviewed 193 out of 194 changed files in this pull request and generated no comments.
Files not reviewed (1)
- ui-v2/biome.json: Language not supported
Comments suppressed due to low confidence (1)
ui-v2/src/components/artifacts/artifact-card.tsx:19
- The change in the Link component now uses a static string for the route, which assumes that the router will use the provided params for dynamic substitution. Please verify that using "/artifacts/key/$key" (without template literal interpolation) correctly maps the route parameter; otherwise, consider restoring dynamic interpolation (e.g. using template literals) if required.
<Link to="/artifacts/key/$key" params={{ key: artifact.key ?? "" }}>
desertaxle
commented
Apr 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR turns on
biome's linting capabilities and fixes all errors raised bybiome. I turned this on because I missed having linting pre-commit, andbiomeis fast enough to run before each commit. We'll still haveeslintrunning in CI to cover gaps inbiome's suggested rules.