update default ui url #18028
Closed
update default ui url #18028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #18028 will not alter performanceComparing Summary
|
| self.__pydantic_fields_set__.remove("ui_url") | ||
| if self.server.ui.api_url is None: | ||
| if self.api.url: | ||
| self.server.ui.api_url = self.api.url |
There was a problem hiding this comment.
I haven't fully thought this through, but I think perhaps this should be "/api" as well here? So in practice, we'd get rid of the if statement one line up, and just unconditionally use "/api" whenever self.server.ui.api_url is None .
Thanks so much for addressing my suggestion so quickly by the way!
Contributor
|
This pull request is stale because it has been open 14 days with no activity. To keep this pull request open remove stale label or comment. |
Contributor
|
This pull request was closed because it has been stale for 14 days with no activity. If this pull request is important or you have more to add feel free to re-open it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #18025