experiment: Separate retries from execution engine #18042
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an experiment to see if we can refactor the task/flow execution engines to extract a pure retry implementation out of them.
The result is a
@retrydecorator that can be used like so:The retry lifecycle is instrumented with callbacks so that users of the retry functionality can take action when the wrapped function succeeds, fails, before a retry delay, etc. These callbacks are used in the task run engine to replicate the existing retry functionality.