Skip to content

Github Action : Sync Labels (Added new labels)#40

Merged
Progi1984 merged 2 commits intoPrestaShop:masterfrom
Progi1984:syncLabel
Mar 19, 2026
Merged

Github Action : Sync Labels (Added new labels)#40
Progi1984 merged 2 commits intoPrestaShop:masterfrom
Progi1984:syncLabel

Conversation

@Progi1984
Copy link
Copy Markdown
Member

Questions Answers
Branch? master
Description? Github Action : Sync Labels (Added new labels)
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
Sponsor company @PrestaShopCorp

@ps-jarvis
Copy link
Copy Markdown

Hello @Progi1984!

This is your first pull request on .github repository of the PrestaShop project.

Thank you, and welcome to this Open Source community!

@github-project-automation github-project-automation bot moved this to Ready for review in PR Dashboard Mar 19, 2026
Copy link
Copy Markdown

@Robin-Fischer-PS Robin-Fischer-PS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two minor typo changes, otherwise LGTM, thanks!

description: "Status: action required, waiting for test feedback"
aliases: ["waiting for QA"] No newline at end of file
description: "Status: Action required, Waiting for test feedback"
aliases: ["waiting for QA"]
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
aliases: ["waiting for QA"]
aliases: ["Waiting for QA"]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's on purpose, this is an alias, so if the repo has this label with this typo it will be correctly replaced with the proper value

- name: "Waiting for QA by Community"
color: '#fbca04'
description: "Status: Action required, Waiting for test feedback by Community"
aliases: ["QA by community"]
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
aliases: ["QA by community"]
aliases: ["QA by Community"]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as before

@ps-jarvis ps-jarvis moved this from Ready for review to Waiting for author in PR Dashboard Mar 19, 2026
@ps-jarvis ps-jarvis added the Waiting for QA Status: Action required, Waiting for test feedback label Mar 19, 2026
@ps-jarvis ps-jarvis moved this from Waiting for author to To be tested in PR Dashboard Mar 19, 2026
@Progi1984 Progi1984 removed Waiting for author Waiting for QA Status: Action required, Waiting for test feedback labels Mar 19, 2026
@Robin-Fischer-PS Robin-Fischer-PS dismissed their stale review March 19, 2026 14:02

'was wrong :'(

Copy link
Copy Markdown

@Robin-Fischer-PS Robin-Fischer-PS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, just like you

@ps-jarvis ps-jarvis added the Waiting for QA Status: Action required, Waiting for test feedback label Mar 19, 2026
@Progi1984 Progi1984 merged commit a69ec31 into PrestaShop:master Mar 19, 2026
@github-project-automation github-project-automation bot moved this from To be tested to Merged in PR Dashboard Mar 19, 2026
@Progi1984 Progi1984 deleted the syncLabel branch March 19, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Waiting for QA Status: Action required, Waiting for test feedback

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants