Fix: BO - dashactivity - module can't be SAVED properly

[Codencode]

Added method "saveDashConfig"

Questions	Answers
Description?	The configuration should be saved
Type?	bug fix
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes PrestaShop/PrestaShop#37033
How to test?

[ps-jarvis]

Hello @Codencode!

This is your first pull request on dashactivity repository of the PrestaShop project.

Thank you, and welcome to this Open Source community!

[florine2623]

Thanks for the PR.
Some checks were not successful, could you check @Codencode ?

[Codencode]

florine2623

Hi @florine2623,
I don’t think I can fix it because, from what I understand, in the definition of the ModuleCode::getPermission() method, the first parameter is defined as array, whereas it should be string.

PS 1.7.7.8

    /**
     * Check employee permission for module.
     *
     * @param array $variable (action)
     * @param Employee $employee
     *
     * @return bool if module can be transplanted on hook
     */
    public function getPermission($variable, $employee = null)
    {
        return Module::getPermissionStatic($this->id, $variable, $employee);
    }

https://github.com/PrestaShop/PrestaShop/blob/753bc2441bc21d79a366f3c7566a03da1ac915eb/classes/module/Module.php#L2768-L2779

PS 8.2.0

    /**
     * Check employee permission for module.
     *
     * @param string $variable (action)
     * @param Employee $employee
     *
     * @return bool if module can be transplanted on hook
     */
    public function getPermission($variable, $employee = null)
    {
        return Module::getPermissionStatic($this->id, $variable, $employee);
    }

https://github.com/PrestaShop/PrestaShop/blob/327c9e42b556fcd676ff02376c00d8d8c3521061/classes/module/Module.php#L2587-L2598

I believe we should simply ignore the warning.

[Hlavtox]

@Codencode Yeah, just add this error here. :-)

https://github.com/PrestaShop/dashactivity/blob/dev/tests/phpstan/phpstan-1.7.7.neon

and here also, because in 1.7.8 it's still an array in the docs and it will also scream at you

https://github.com/PrestaShop/dashactivity/blob/dev/tests/phpstan/phpstan-1.7.8.neon

[Codencode]

@Codencode Yeah, just add this error here. :-)

https://github.com/PrestaShop/dashactivity/blob/dev/tests/phpstan/phpstan-1.7.7.neon

and here also, because in 1.7.8 it's still an array in the docs and it will also scream at you

https://github.com/PrestaShop/dashactivity/blob/dev/tests/phpstan/phpstan-1.7.8.neon

@Hlavtox,
I hope I did well, I added the errors to the files in my repository and uploaded them.
I never added "ignoreErrors"

Thanks!

[Hlavtox]

@Codencode Good job, all good now! :-)

[Hlavtox]

@florine2623 Ready to go! :-)

[Codencode]

@Codencode Good job, all good now! :-)

@Hlavtox Thank you!

[florine2623]

Hello @Codencode ,

Thanks for the PR !

Wrks as expected as you can see :

Screen.Recording.2024-10-01.at.14.25.55.mov

It is QA ✅

[Hlavtox]

Thanks everyone!