Skip to content

Adapt selectors for new branding #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 6, 2024
Merged

Adapt selectors for new branding #115

merged 2 commits into from
Aug 6, 2024

Conversation

@jolelievre
Copy link
Contributor

@jolelievre jolelievre commented Aug 6, 2024 •
edited
Loading

Questions Answers
Description? Adapt selectors for new branding, and make make test compatible with Mac OS
Type? refactor
BC breaks? no
Deprecations? no
Fixed ticket? ~
Sponsor company ~
How to test? To validate that these changes are compatible with develop branch even without the reskin a PR has been created based on this branch PrestaShop/PrestaShop#36681 And here is the UI tests running based on these modifications https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/10266090987

@jolelievre jolelievre force-pushed the reskin branch 2 times, most recently from c6d5347 to 26fbbc5 Compare August 6, 2024 10:55
@nesrineabdmouleh nesrineabdmouleh added the QA ✔️ Status: QA-Approved label Aug 6, 2024
@nesrineabdmouleh nesrineabdmouleh merged commit b46a9c1 into PrestaShop:main Aug 6, 2024
@Progi1984 Progi1984 added this to the 0.0.12 milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@nesrineabdmouleh nesrineabdmouleh nesrineabdmouleh approved these changes

Assignees

No one assigned

Labels

QA ✔️ Status: QA-Approved

Projects

PR Dashboard
Archived in project

Milestone

0.0.12

Development

Successfully merging this pull request may close these issues.

3 participants

@jolelievre @Progi1984 @nesrineabdmouleh