Skip to content

Conversation

@Quetzacoalt91
Copy link
Contributor

@Quetzacoalt91 Quetzacoalt91 commented Jul 14, 2021

Following https://twitter.com/mheap/status/1411390113230344197?s=20, this PR introduces npm cache in our JS wokflows.

This branch has been pushed on the main repo as I need to see the impact on the cache.

@Quetzacoalt91 Quetzacoalt91 added enhancement Type: Improvement VueJS Tech: VueJS labels Jul 14, 2021
@Quetzacoalt91 Quetzacoalt91 force-pushed the ci-cache-npm-deps branch 2 times, most recently from 8b93955 to da32e2f Compare July 14, 2021 10:36
@Quetzacoalt91 Quetzacoalt91 added the WIP Status: Work In Progress label Jul 14, 2021
@Quetzacoalt91
Copy link
Contributor Author

Quetzacoalt91 commented Jul 14, 2021

Can't go further at the moment, as we can't specify a working directory to use when installing and building application.

We should keep a look at:

@Quetzacoalt91 Quetzacoalt91 marked this pull request as draft July 14, 2021 10:44
@Quetzacoalt91 Quetzacoalt91 force-pushed the ci-cache-npm-deps branch 2 times, most recently from 9fbb7fb to 4fd3196 Compare July 14, 2021 11:03
@amaury-hanser
Copy link
Contributor

@Quetzacoalt91 , looks like actions/setup-node#299 has been merged !

@Quetzacoalt91 Quetzacoalt91 force-pushed the ci-cache-npm-deps branch 2 times, most recently from f261c69 to e05e109 Compare August 16, 2021 15:51
@Quetzacoalt91 Quetzacoalt91 removed the WIP Status: Work In Progress label Aug 16, 2021
@Quetzacoalt91 Quetzacoalt91 marked this pull request as ready for review August 16, 2021 16:08
@Quetzacoalt91
Copy link
Contributor Author

Ready for review!

@Quetzacoalt91 Quetzacoalt91 merged commit f0269c9 into master Aug 17, 2021
@Quetzacoalt91 Quetzacoalt91 deleted the ci-cache-npm-deps branch August 17, 2021 13:32
@Quetzacoalt91 Quetzacoalt91 mentioned this pull request Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Type: Improvement VueJS Tech: VueJS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants