feat(friends): add GetUserFriendsData rpc#19
Conversation
|
The latest Buf updates on your PR. Results from workflow Validate Pull Request / check_buf (pull_request).
|
DaniElectra
left a comment
DaniElectra
left a comment
There was a problem hiding this comment.
Thank you! I have some suggestions that would be awesome to add here
| uint64 message_updated_at = 9; | ||
| uint64 mii_modified_at = 10; | ||
| uint64 last_online = 11; | ||
| MiiV2 mii = 12; |
There was a problem hiding this comment.
The 3DS Mii holds more information alongside the name and the raw data, such as the character set and the profanity flag. Do we want to store that alongside the other fields too?
Alongside that, the raw data here is encrypted with AES-CCM with a twist. I'm not sure how feasible it would be to implement this on the Go side, but it would definitely be nice to support
There was a problem hiding this comment.
Alongside that, the raw data here is encrypted with AES-CCM with a twist. I'm not sure how feasible it would be to implement this on the Go side, but it would definitely be nice to support
I guess what would you actually be looking to have included here? Would the thought be to have the friends server decrypt the data before sending it out?
There was a problem hiding this comment.
I would suggest just duplicating the data. Send both the encrypted and decrypted versions. My gut tells me we'd never need to encrypted version, but given how weird some things are setup with NEX it's possible we may run into a situation where we need the original, encrypted, Mii data of a user as part of a game server. So just do both, to be safe
Either that or always send the encrypted data with a docs comment noting that it's encrypted, and expect the caller the decrypt it each time. But I suspect most of our use cases will need the decrypted version
jonbarrow
left a comment
jonbarrow
left a comment
There was a problem hiding this comment.
This is the only actual issue I can see, otherwise this looks great! Thanks
3 participants
Resolves #XXX
Changes:
This adds an additional rpc for fetching your friends list data, with the main intention to get the online status and current title ID