Skip to content

Make forum in nav with dropdown text translateable#427

Merged
limesdotpink merged 2 commits intoPretendoNetwork:devfrom
LelouchFR:fix-forum-nav
Mar 17, 2026
Merged

Make forum in nav with dropdown text translateable#427
limesdotpink merged 2 commits intoPretendoNetwork:devfrom
LelouchFR:fix-forum-nav

Conversation

@LelouchFR
Copy link
Copy Markdown
Contributor

Resolves #418

Changes:

moved hard-coded string for dropdown and title of the forum in the nav to the locales en_US and added fr_FR version.

limesdotpink
limesdotpink previously approved these changes Mar 17, 2026
Copy link
Copy Markdown
Member

@limesdotpink limesdotpink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution :)

@limesdotpink limesdotpink changed the base branch from master to dev March 17, 2026 11:58
@limesdotpink limesdotpink dismissed their stale review March 17, 2026 11:58

The base branch was changed.

Copy link
Copy Markdown
Member

@limesdotpink limesdotpink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double approving because i forgot to change the target branch

@limesdotpink limesdotpink merged commit dff3511 into PretendoNetwork:dev Mar 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement]: Make the “Forum” harder link and description translateable

2 participants