Perf/professional hardening#4
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 87eb05e423
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| target.IsIdleServerDisabled = source.IsIdleServerDisabled; | ||
| target.IsRegistryPriorityEnabled = source.IsRegistryPriorityEnabled; |
There was a problem hiding this comment.
Preserve process toggle flags when applying refresh snapshots
Do not overwrite IsIdleServerDisabled and IsRegistryPriorityEnabled from the incoming snapshot here. ProcessService does not hydrate those fields when building snapshot models, so every refresh writes the defaults back onto existing rows. In practice, if a user enables either toggle for a process, the next refresh clears that state in the in-memory model and later selections show the wrong value, causing confusing and incorrect UI behavior.
Useful? React with 👍 / 👎.
PrimeBuild-pc
left a comment
There was a problem hiding this comment.
Reviewed the changes and validation results. CI, CodeQL, and local validation passed. Approved for merge.
Summary
This PR hardens ThreadPilot’s background behavior, process refresh pipeline, affinity/power-plan automation, and UX clarity.
Main goals:
Type of Change
What Changed
Performance / background behavior
AppRefreshPolicyto centralize refresh decisions.Process refresh reliability
Affinity and power-plan automation
UX improvements
Tests
Validation
Local validation passed:
dotnet build ThreadPilot_1.slndotnet test ThreadPilot_1.slngit diff --checkCurrent test count: 104 passing.
Known local warnings are pre-existing analyzer/style warnings plus NU1900 when NuGet vulnerability metadata cannot be fetched.
Security and Risk Notes
This PR touches elevated/system-adjacent functionality, including process enumeration, processor affinity, power plans, process monitoring, tray behavior, and Windows tweak UI. Changes were intentionally scoped to make these paths safer:
Manual QA Checklist
Checklist