Fix streaming validation dataset causing infinite loop#43
Open
vominh1919 wants to merge 1 commit intoPrimeIntellect-ai:mainfrom
Open
Fix streaming validation dataset causing infinite loop#43vominh1919 wants to merge 1 commit intoPrimeIntellect-ai:mainfrom
vominh1919 wants to merge 1 commit intoPrimeIntellect-ai:mainfrom
Conversation
When streaming=True, the validation dataset is an IterableDataset with no __len__, causing evaluate_model to loop forever. Fix by loading validation separately with streaming=False while keeping training data streaming. Fixes PrimeIntellect-ai#42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42
Problem
In
train_diloco_torch.py, the validation dataset was loaded as part of a streaming (IterableDataset) load. Theevaluate_modelfunction iterates overeval_dataloaderwith aforloop, which never terminates because streaming datasets have no__len__and never signal end-of-data.Fix
validationfrom the streamingload_datasetcall (training only)streaming=Falseonly wheneval_steps is not NoneThis keeps training efficient with streaming while ensuring validation has a finite, known length.