[Bug] ACP: every IPython tool call is titled "IPython cell" and shows no cell source #1355
AndriyPytel
started this conversation in
Bug reports
Replies: 1 comment
|
@sethkarten same note here, since ACP mode is yours. This is the other one I hit daily driving Prime Agent over ACP: because IPython is the model-facing tool, nearly every row in the transcript is titled Patch is up as #1309 with unit tests over the event mapper. The one non-obvious part is that the cell has to be re-sent on |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Affected area
Coding agent and CLI (ACP mode)
What happened?
Every IPython tool call reaches an ACP client titled
IPython cell, with the cell source only inrawInput. IPython is Prime Agent's model-facing tool, so that is the title of nearly every row in the session: the transcript becomes a column of identical rows. A client that renders content blocks rather thanrawInputshows those rows empty, so there is nothing to tell one cell from another.Steps to reproduce
prime-agent --mode acpand connect an ACP client.tool_callarrives withtitle: "IPython cell".Expected behavior
The call is titled by what the cell actually does — its first meaningful line — and the source travels as content, not only as
rawInput, so a content-rendering client shows the cell.Two details matter: a leading cell magic should be paired with the line after it (
%%bashalone names the interpreter, not the work), and the source has to be repeated ontool_call_update, because a client replaces a tool call's content on update rather than appending — otherwise the cell disappears the moment the call completes.Prime Agent version
0.7.1 (also reproduced on
mainat 7787f07)Environment
macOS,
prime-agent --mode acpdriven over stdio by an ACP clientAdditional context
Tracked as #1307. A focused patch is up as #1309, with tests in
test/acp-events.test.tscovering a plain cell, a%%bashcell, a blank cell, a 200-character line, and completion carrying both the cell and the result;npm run checkpasses.Opening this Discussion because the new contribution process routes intake here.
All reactions