This repository was archived by the owner on Jan 27, 2026. It is now read-only.
Discovery state change tests#171
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the discovery node synchronization logic and adds tests to validate state changes. Key changes include:
- Refactoring the get_nodes method to loop over discovery nodes via a new sync_single_node_with_discovery function.
- Converting the node identifier to an Address type and updating status transition logic.
- Adding tests for node synchronization behavior.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces changes to improve how discovery state changes are synchronized and adds tests to validate these behaviors.
- Replace unwrap calls with proper error propagation via the ? operator.
- Introduce a new function, sync_single_node_with_discovery, to update node states based on discovery data.
- Add a test for sync_single_node_with_discovery to verify state transitions.
JannikSt
added a commit
that referenced
this pull request
Apr 12, 2025
* rewrite orchestrator discovery sync to make it testable * fix & test discvoery state changes, add logs when state changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.