Fix: node recovery edge case

[JannikSt]

No description provided.

[Copilot]

Pull Request Overview

This PR fixes a node recovery edge case by updating the logic used for synchronizing node status and ejection. It adds a new helper function (is_node_in_pool) with separate implementations for testing and production and updates the conditions used to set node status upon receiving a heartbeat.

Comments suppressed due to low confidence (2)

orchestrator/src/node/status_update.rs:60

• The #[cfg(not(test))] branch in is_node_in_pool is not directly covered by tests. Consider adding tests for scenarios where the node is not in the pool to ensure production behavior is verified.

async fn is_node_in_pool(&self, node: &OrchestratorNode) -> bool {

orchestrator/src/node/status_update.rs:609

• The updated test assertion reflects a change in recovery behavior. Ensure that additional tests cover all relevant scenarios regarding node status transitions, particularly for nodes transitioning from Dead to Healthy.

assert_eq!(node.status, NodeStatus::Healthy);