Skip to content
This repository was archived by the owner on Jan 27, 2026. It is now read-only.

Discovery Service Timestamps#175

Merged
JannikSt merged 1 commit into
developfrom
improvement/discovery-svc-timestamps-and-sorting
Mar 26, 2025
Merged

Discovery Service Timestamps#175
JannikSt merged 1 commit into
developfrom
improvement/discovery-svc-timestamps-and-sorting

Conversation

@JannikSt
Copy link
Copy Markdown
Member

No description provided.

@JannikSt JannikSt requested a review from Copilot March 26, 2025 22:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces timestamp support for Discovery nodes, enabling tracking of when nodes are updated and created. Key changes include sorting nodes by timestamp in the store layer, adding new timestamp fields (last_updated and created_at) in the shared DiscoveryNode model, and updating tests to verify the timestamp behavior.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
discovery/src/store/node_store.rs Added sorting of nodes based on timestamp fields
shared/src/models/node.rs Introduced last_updated and created_at fields in the DiscoveryNode model
shared/Cargo.toml Added the chrono dependency with serde support
discovery/src/api/routes/node.rs Updated tests to verify the proper handling of timestamp fields
orchestrator/src/discovery/monitor.rs Updated test instantiation of nodes with explicit timestamp values
shared/src/utils/google_cloud.rs Modified test to skip execution when required environment variables are missing
Comments suppressed due to low confidence (1)

shared/src/utils/google_cloud.rs:134

  • The environment variable name 'S3_CREDENTIALS' appears inconsistent with the context of Google Cloud usage; consider renaming it to something like 'GOOGLE_CLOUD_CREDENTIALS' for clarity.
let credentials_base64 = match std::env::var("S3_CREDENTIALS") {

@JannikSt JannikSt merged commit f21bcb8 into develop Mar 26, 2025
JannikSt added a commit that referenced this pull request Apr 12, 2025
@JannikSt JannikSt deleted the improvement/discovery-svc-timestamps-and-sorting branch June 25, 2025 13:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants