This repository was archived by the owner on Jan 27, 2026. It is now read-only.
Discovery Service Timestamps#175
Merged
JannikSt merged 1 commit intoMar 26, 2025
Merged
Conversation
…fix google cloud testing bug
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces timestamp support for Discovery nodes, enabling tracking of when nodes are updated and created. Key changes include sorting nodes by timestamp in the store layer, adding new timestamp fields (last_updated and created_at) in the shared DiscoveryNode model, and updating tests to verify the timestamp behavior.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| discovery/src/store/node_store.rs | Added sorting of nodes based on timestamp fields |
| shared/src/models/node.rs | Introduced last_updated and created_at fields in the DiscoveryNode model |
| shared/Cargo.toml | Added the chrono dependency with serde support |
| discovery/src/api/routes/node.rs | Updated tests to verify the proper handling of timestamp fields |
| orchestrator/src/discovery/monitor.rs | Updated test instantiation of nodes with explicit timestamp values |
| shared/src/utils/google_cloud.rs | Modified test to skip execution when required environment variables are missing |
Comments suppressed due to low confidence (1)
shared/src/utils/google_cloud.rs:134
- The environment variable name 'S3_CREDENTIALS' appears inconsistent with the context of Google Cloud usage; consider renaming it to something like 'GOOGLE_CLOUD_CREDENTIALS' for clarity.
let credentials_base64 = match std::env::var("S3_CREDENTIALS") {
JannikSt
added a commit
that referenced
this pull request
Apr 12, 2025
…fix google cloud testing bug (#175)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.