This repository was archived by the owner on Jan 27, 2026. It is now read-only.
Fix: chainsync can break on old data#178
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses potential failures when syncing node data by adding robust error handling and refactoring inline error-prone code into a dedicated async function. Key changes include:
- Replacing unwrap calls with error handling via map_err.
- Introducing the async function sync_single_node to encapsulate node synchronization logic.
- Updating error types from Result<()> to Result<(), Error> for improved error propagation.
Comments suppressed due to low confidence (2)
discovery/src/chainsync/sync.rs:36
- [nitpick] The variable 'n' is ambiguous. Consider renaming it to a more descriptive name such as 'updated_node' for better code clarity.
let mut n = node.clone();
discovery/src/chainsync/sync.rs:40
- [nitpick] Consider using a structured logging framework instead of eprintln for error reporting to better support production diagnostics and log management.
eprintln!("Failed to parse provider address: {}", e);
JannikSt
added a commit
that referenced
this pull request
Apr 12, 2025
* fix chainsync can break on old data * cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.