This repository was archived by the owner on Jan 27, 2026. It is now read-only.
Fix: discovery wrong status on missing pool#179
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the discovery service incorrectly panics and returns a 503 error when a non-existent pool is queried by instead returning a 404 with an appropriate message.
- Replaces a panic (unwrap) with proper error handling using a match expression.
- Sends an HTTP 404 response when the pool is not found.
JannikSt
added a commit
that referenced
this pull request
Apr 12, 2025
* add proper 404 response when pool is not found
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovery service sends 503 and panicks instead of sending a 404 when you request a pool id that does not exist.