This repository was archived by the owner on Jan 27, 2026. It is now read-only.
allow parsing compute specs from string#244
Merged
Merged
Conversation
…etting Improvement/shm size setting
* feature: ability to disable node ejection
* improve the resiliency of validator
* add improvement to metrics reporting
…enge very basic validator functionality
* make discovery redis handling more resilient
* adjust bridge setup to make it more resilient
* ensure we do not stop reading after connection drop
* make taskbridge even more robust and add concurrent samples
* add orchestrator logging
* fix orchestrator discovered edgecase where node is in discovered state but already active on chain
Fix: The orchestrator /nodes api returned the wrong string representation of addresses
* link validator health with loop execution - this way k8s (or similar) can restart when loop fails
* add more explicit logging to bridge
* refactor task handling
* reduce log noise
Contributor
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
worker/src/services/discovery.rs:56
- Consider also logging the full error details (e.g. error_text) when a non-successful response is received so that debugging issues in production becomes easier.
let status = response.status();
mattdf
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to parse the compute specs from the compute pool URI to ensure we: