This repository was archived by the owner on Jan 27, 2026. It is now read-only.
Fix: pool invite adjustment#265
Merged
Merged
Conversation
JannikSt
requested review from
Copilot and
mattdf
and removed request for
Copilot
Contributor
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
worker/src/api/routes/invite.rs:24
- Consider adding unit tests to cover the invite validation logic, specifically testing both scenarios when compute_pool_id is provided and when it is None.
if let Some(pool_id) = app_state.system_state.compute_pool_id.clone() {
worker/src/cli/command.rs:179
- [nitpick] The parameter 'compute_pool_id' may be confused with other pool identifiers; consider using a more descriptive name if context permits, or document its purpose clearly.
Some(compute_pool_id.to_string()),
mattdf
approved these changes
Apr 15, 2025
…node ip addresses for pool when they are active in other pools
mattdf
approved these changes
Apr 15, 2025
JannikSt
added a commit
that referenced
this pull request
Apr 15, 2025
* Fix: pool invite adjustment (#265) * only accept pool invites from correct pool id and only if heartbeat is off * prevent nodes from overwriting data when they are active, filter out node ip addresses for pool when they are active in other pools * handle double work submission error due to latency (#266) * Improvement: Discovery heartbeat based on chainsync (#267) * adjust discovery health based on chainsync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure we validate pool invite before checking onchain