fix: release workflow triggers wheel and docker builds#19
Merged
Conversation
ApprovabilityVerdict: Approved This is a minor CI/CD change that adds workflow triggers to automatically kick off wheel and Docker builds when a release is created. No production code or runtime behavior is affected. You can customize Macroscope's approvability policy. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tags created by GITHUB_TOKEN don't trigger other workflows. Added workflow_dispatch calls to build-wheel.yml and build-push-image.yml after tag creation, using --ref to point at the tag so version extraction works correctly.
Note
Medium Risk
Changes the release automation to programmatically trigger other GitHub Actions workflows and expands workflow permissions (
actions: write), which can affect release/build integrity if misconfigured.Overview
After creating/pushing the release tag and GitHub Release, the
release.ymlworkflow now explicitly triggersbuild-wheel.ymlandbuild-push-image.ymlviagh workflow run, using--refto run against the new tag.The workflow permissions are expanded to include
actions: writeto allow dispatching these downstream workflows.Reviewed by Cursor Bugbot for commit 51b9d00. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Trigger wheel and Docker image builds from the release workflow
After creating a GitHub release, release.yml now triggers
build-wheel.ymlandbuild-push-image.ymlusing the release tag as the ref. The job also gainsactions: writepermission to allow dispatching these workflows via the GitHub CLI.Macroscope summarized 51b9d00.