ENG-3780: use model id in body for routing#40
Merged
Conversation
ApprovabilityVerdict: Needs human review This change modifies request routing behavior to filter workers based on the model specified in the request body. While framed as a bug fix, it changes which workers receive requests in production, affecting routing decisions that weren't previously model-filtered in this code path. You can customize Macroscope's approvability policy. Learn more. |
Use request body models as worker filters only when the router registry has indexed that model, while keeping run-scoped requests strict. Treat rerank's "default" sentinel as unspecified so omitted-model rerank requests continue to route normally. Also sync all advertised worker models during startup and add_worker so workers serving multiple models or LoRA adapters are routable immediately, before the next health refresh. Adds regression coverage for indexed LoRA routing, rerank default handling, and multi-model worker registration.
JannikSt
approved these changes
May 29, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
modelwhen callers passmodel_id = None.model: "rft-run-1"only reaches a worker indexed for that LoRA, not a base-model-only worker.
Test Plan
able to repoduce the model not found issue on develop during scale up events:
will test the changes on this branch against the same run setup on develop to confirm fix
Test Result
https://dev-cloud-run-abruy2xuia-ew.a.run.app/dashboard/training/zzf3t7zji3gcb2xc1ji0kmub << ran the same run with the updated router tag and had claude monitor the logs for the entire run:
Essential Elements of an Effective PR Description Checklist