chore: reuse math rubric in hybrid math rubric#1043
Merged
mikasenghaas merged 3 commits intomainfrom Mar 20, 2026
Merged
Conversation
HybridMathRubric now holds an internal MathRubric instance and delegates math_verify calls to it instead of running parse()/verify() synchronously on the event loop. This reuses MathRubric's ThreadPoolExecutor-based, non-blocking verification with hard timeout and executor auto-scaling, preventing sympy from freezing the event loop on pathological expressions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
samsja
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
HybridMathRubric now holds an internal MathRubric instance and delegates math_verify calls to it instead of running parse()/verify() itself. This reuses MathRubric's ThreadPoolExecutor-based, non-blocking verification with hard timeout and executor auto-scaling.
Type of Change
Testing
uv run pytestlocally.Checklist
Additional Notes
Note
Medium Risk
Changes core math-scoring behavior by routing
HybridMathRubricthroughMathRubric’s executor-based verification and new timeout/worker settings, which may alter pass/fail outcomes and performance under load.Overview
Hybrid math grading now reuses
MathRubricfor local rule-based verification instead of callingmath_verifydirectly.HybridMathRubricconstructs an internalMathRubric(with configurabletimeout_seconds/max_workers), clears its auto-registered reward funcs, and delegatesmath_verify_scoretoMathRubric.correct_answer.Minor cleanup includes removing direct
math_verifyimports/logging inHybridMathRubricand tightening docstrings/behavior around when the LLM judge fallback runs.Written by Cursor Bugbot for commit a8e2704. This will update automatically on new commits. Configure here.