vf-eval: replace -d/--debug with --disable-tui, rename --tui to --fullscreen#1183
Merged
mikasenghaas merged 5 commits intomainfrom Apr 19, 2026
Merged
vf-eval: replace -d/--debug with --disable-tui, rename --tui to --fullscreen#1183mikasenghaas merged 5 commits intomainfrom
mikasenghaas merged 5 commits intomainfrom
Conversation
Rename the eval CLI's "disable Rich display" flag to the clearer `--disable-tui`. Keep `-d`/`--debug` as a backward-compatible alias that emits a DeprecationWarning. Mirror the rename in `EvalConfig` (`debug` -> `disable_tui`), the log-hint subtitle, docs table, and test fixtures. TOML configs accept either `debug` or `disable_tui` during the deprecation window. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…lscreen `--tui`/`-u` was confusingly named (the Rich display is always on unless `--disable-tui` is passed — `--tui` only controlled alternate-screen buffering). Rename it to `--fullscreen`; keep `--tui`/`-u` as a DeprecationWarning alias. Raise a `SystemExit` if both `--disable-tui` and `--fullscreen` are set, since they address orthogonal concerns and combining them is meaningless. Also rename `run_evaluations_tui(..., tui_mode=...)` to `fullscreen=...` to match. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Rather than shipping deprecation warnings, just break the old flags. Users must now use `--disable-tui` (was `-d`/`--debug`) and `--fullscreen` (was `-u`/`--tui`). Also remove the TOML `debug` fallback in `EvalConfig` construction — TOML configs must use `disable_tui`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mikasenghaas
changed the title
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 36dc236. Configure here.
The TOML config validator's `valid_fields` set was still listing the removed `debug` key and omitting `disable_tui`. That meant TOML configs using the new key would fail validation, while configs still using the old key would pass validation but be silently ignored (no longer read by `build_eval_config`). Fix by swapping the key in `valid_fields`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
xeophon
approved these changes
Apr 19, 2026
Member
|
Actually sorry can we revert this @mikasenghaas @xeophon ? We should be careful with breaking changes for the primary UX. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clean up the
vf-evaldisplay flags. Two separate concerns were conflated under names that made them hard to reason about:-d/--debug, now-d/--disable-tui.-u/--tui, now-f/--fullscreen.Changes
--disable-tui(-d) and--fullscreen(-f) as the canonical flag names.full logs: --disable-tui) and docs table.SystemExitif both--disable-tuiand--fullscreenare passed.-d/--debug-d/--disable-tui-u/--tui-f/--fullscreenThe
-dshort flag is preserved but now maps to--disable-tui.-uis no longer accepted — use-f/--fullscreeninstead. Runningvf-eval env-id --debugorvf-eval env-id --tuiafter this change will fail with an argparseunrecognized argumentserror. Any downstream tooling or TOML configs that setdebug=trueonEvalConfigwill also need updating.🤖 Generated with Claude Code
Note
Medium Risk
Medium risk due to breaking CLI/TOML config surface changes (
--debug/--tuiremoved) and updated config schema (debug→disable_tui), which can break downstream scripts and saved configs if not migrated.Overview
Clarifies
vf-evaldisplay controls by renaming--tuito--fullscreen(alternate screen buffer) and--debugto--disable-tui(turn off Rich display and use normal logging/tqdm), and updates docs/tests accordingly.Adds a guard in
verifiers/scripts/eval.pythat exits when--disable-tuiand--fullscreenare both provided, and propagates the renamed setting throughEvalConfig, TOML validation (eval_utils.valid_fields), env serverconsole_logging, and the on-screen log hint text.Reviewed by Cursor Bugbot for commit 4faaf5d. Bugbot is set up for automated code reviews on this repo. Configure here.