Skip to content

Update SandboxMixin#1222

Merged
DamianB-BitFlipper merged 7 commits intomainfrom
update-sandbox-mixin
Apr 22, 2026
Merged

Update SandboxMixin#1222
DamianB-BitFlipper merged 7 commits intomainfrom
update-sandbox-mixin

Conversation

@DamianB-BitFlipper
Copy link
Copy Markdown
Collaborator

@DamianB-BitFlipper DamianB-BitFlipper commented Apr 21, 2026

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Test improvement

Testing

  • All existing tests pass when running uv run pytest locally.
  • New tests have been added to cover the changes

Checklist

  • My code follows the style guidelines of this project as outlined in AGENTS.md
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Additional Notes


Note

Low Risk
Documentation-only change; no runtime behavior or APIs are modified.

Overview
Updates verifiers/envs/experimental/README.md to document SandboxMixin support for both container and VM sandboxes, including how to request VMs (and GPU VMs) via CreateSandboxRequest.

Clarifies current feature parity/limitations by noting that port exposure and SSH are container-only while common operations (file I/O, background jobs, cleanup) behave the same across sandbox types.

Reviewed by Cursor Bugbot for commit edb2dd0. Bugbot is set up for automated code reviews on this repo. Configure here.

@DamianB-BitFlipper DamianB-BitFlipper marked this pull request as ready for review April 21, 2026 18:51
Copy link
Copy Markdown
Member

@mikasenghaas mikasenghaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah but it looks like we alr support the vm attr bc its part of CreateSandboxRequest? in that case, i dont acc think we need any additional wiring here

Comment thread assets/lab/environments/AGENTS.md Outdated
Comment thread docs/environments.md Outdated
Comment thread environments/AGENTS.md Outdated
Comment thread verifiers/envs/experimental/sandbox_mixin.py Outdated
Comment thread verifiers/envs/experimental/sandbox_mixin.py Outdated
Comment thread verifiers/envs/experimental/sandbox_mixin.py Outdated
Comment thread verifiers/envs/experimental/sandbox_mixin.py Outdated
Comment thread verifiers/envs/experimental/sandbox_mixin.py Outdated
@DamianB-BitFlipper DamianB-BitFlipper merged commit 35a108a into main Apr 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants