Skip to content

Revert "types: TaskSet.filter / .take return Self, not TaskSet (#1232)" #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikasenghaas merged 3 commits into from
Apr 23, 2026
+4 −4
Merged

Revert "types: TaskSet.filter / .take return Self, not TaskSet (#1232)" #1237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f948a18
Revert "types: TaskSet.filter / .take return Self, not TaskSet (#1232)"
mikasenghaas Apr 23, 2026
9b74ce9
ci: add python 3.10 to test matrix
mikasenghaas Apr 23, 2026
6bdd589
ci: add python 3.11 to test matrix
mikasenghaas Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["3.12", "3.13"]
python-version: ["3.10", "3.11", "3.12", "3.13"]

steps:
- uses: actions/checkout@v4
Expand Down
6 changes: 3 additions & 3 deletions verifiers/envs/experimental/composable/task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ async def evaluate(self, sandbox_client, sandbox_id, state) -> float: ...
from importlib.abc import Traversable
from pathlib import Path
from types import ModuleType
from typing import Any, Callable, Self
from typing import Any, Callable

from verifiers.envs.experimental.composable._filter import _resolve_filter_fn
from verifiers.types import Messages, State
Expand Down Expand Up @@ -279,13 +279,13 @@ def __getitem__(self, i: int) -> Task:

# -- Combinators ---------------------------------------------------------

def filter(self, predicate: Callable[[dict], bool]) -> Self:
def filter(self, predicate: Callable[[dict], bool]) -> TaskSet:
clone = object.__new__(type(self))
clone.__dict__.update(self.__dict__)
clone._dataset = self._dataset.filter(predicate)
return clone

def take(self, n: int) -> Self:
def take(self, n: int) -> TaskSet:
clone = object.__new__(type(self))
clone.__dict__.update(self.__dict__)
clone._dataset = self._dataset.select(range(min(n, len(self._dataset))))
Expand Down
Loading