fix: default rollout max_retries to 3#1533
Merged
Merged
Conversation
Default the eval rollout retry count for transient infrastructure errors to 3 instead of 0, via EvalConfig.max_retries, the `vf-eval --max-retries` CLI flag, and the eval config ingestion default. Co-authored-by: Cursor <cursoragent@cursor.com>
ApprovabilityVerdict: Approved Simple default value change from 0 to 3 for retry behavior on transient infrastructure errors. The change is consistent across all relevant locations (docs, CLI, config parsing, type definition) with clear intent and limited scope. You can customize Macroscope's approvability policy. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
3instead of0.EvalConfig.max_retries, thevf-eval --max-retriesCLI flag (default + help text), and the eval config ingestion fallback.EvalConfigreference docs to match.Breaking
vf-eval/ eval configs now retry transient infra errors up to 3 times by default. To restore the previous behavior, pass--max-retries 0(or setmax_retries = 0in the eval config).Made with Cursor
Note
Low Risk
Default-only behavior change for eval retries; no auth or data paths. Slightly longer runs on flaky infra unless callers opt out with max_retries=0.
Overview
Changes the default rollout retry count for transient infrastructure errors from 0 to 3 across eval configuration.
EvalConfig.max_retries,vf-eval --max-retries(default and help text), and the eval config builder fallback whenmax_retriesis omitted now use 3. Reference docs forEvalConfigmatch.Breaking: Evals retry failed rollouts up to three times by default (via
maybe_retryaround rollout/group execution). Use--max-retries 0ormax_retries = 0in config to keep the old no-retry behavior.Reviewed by Cursor Bugbot for commit 4cbdeba. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Default
max_retriesto 3 in rollout eval configurationChanges the default value of
max_retriesfrom0to3inEvalConfig, the CLI argument parser, and the TOML config loader ineval.py. Documentation indocs/reference.mdis updated to match. Behavioral Change: any eval run that previously relied on the default of0retries will now retry up to 3 times automatically.Macroscope summarized 4cbdeba.