integrating into my project#4
Closed
sunildkumar wants to merge 1 commit into
Closed
Conversation
Member
|
does this need to be a PR to the main repo? what's the problem being fixed? |
Author
|
AHHH sorry. I didn't mean to PR this against the main copy of the code - meant to be my fork... |
3 tasks
hallerite
added a commit
that referenced
this pull request
May 6, 2026
Adds two new optional fields to ClientConfig: - preserve_all_thinking - preserve_thinking_between_tool_calls RendererClient._get_renderer_or_pool reads them off the ClientConfig and forwards to create_renderer_pool, which binds them as defaults on every pooled renderer instance (renderers PR #4). Added to the pool cache key so a renderer built with the flag off can't satisfy a request that asked for it on. Off by default — zero behaviour change for existing callers. Bumps the renderers source pin to 736f47f (PR #4: feat/preserve-thinking-defaults). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
hallerite
added a commit
that referenced
this pull request
May 6, 2026
Adds two new optional fields to ClientConfig: - preserve_all_thinking - preserve_thinking_between_tool_calls RendererClient._get_renderer_or_pool reads them off the ClientConfig and forwards to create_renderer_pool, which binds them as defaults on every pooled renderer instance (renderers PR #4). Added to the pool cache key so a renderer built with the flag off can't satisfy a request that asked for it on. Off by default — zero behaviour change for existing callers. Bumps the renderers source pin to 736f47f (PR #4: feat/preserve-thinking-defaults). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
hallerite
added a commit
that referenced
this pull request
May 12, 2026
…irection renderer_client (bugbot #3, high): the previous isinstance(renderer, MultimodalRenderer) check was performed against the outer renderer parameter, which in production is a RendererPool. RendererPool was not a Renderer subclass, so the multimodal branch never fired and the PR's mm carry-forward was silently broken under pooled use. Renderers PR now has RendererPool implement the Renderer protocol structurally, and this side dispatches via the cached is_multimodal(r) helper which works on either a bare renderer or a pool. save_utils (bugbot #2, medium): is_json_serializable previously whitelisted torch tensors and renderer dataclasses, but make_serializable has no handler for them — it would stringify to "tensor(...)" garbage if anything actually hit JSON. The whitelist worked only because the orchestrator excludes "trajectory" at the JSONL boundary. Restore the honest JSON-only contract and bypass the gate explicitly in state_to_output for col == "trajectory" (where msgpack handles tensors via its custom encoder). save_utils (bugbot #4, low): _strip_intermediate_mm_data was stripping step["tokens"]["multi_modal_data"] but not the duplicate at step["response"].message.tokens.multi_modal_data. The Pydantic Response serialization preserves it through msgpack via model_dump(), so the O(N²) bloat the function targets was only halved. Now strips both. Also drop the pool-vs-bare-renderer branching ladder via _maybe_offload (asyncio.to_thread iff pool); pool's checkout is now an implementation detail of the pool itself. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.